refactor: remove deprecated module(compatibility_level) by jbedard · Pull Request #2735 · aspect-build/rules_js

jbedard · 2026-02-27T02:39:31Z

Changes are visible to end-users: no

Test plan

Covered by existing test cases

aspect-workflows · 2026-02-27T02:39:46Z

Bazel 7 (Test)

All tests were cache hits

317 tests (100.0%) were fully cached saving 44s.

Bazel 8 (Test)

275 test targets passed

Targets

//:node_modules_build_test [k8-fastbuild]                                                            74ms
//examples/genrule:test_acorn [k8-fastbuild]                                                         43ms
//examples/js_binary:aspect_bin_a_test [k8-fastbuild]                                                121ms
//examples/js_binary:case7_test [k8-fastbuild]                                                       127ms
//examples/js_binary:test13-1_mjs [k8-fastbuild]                                                     106ms
//examples/js_binary:test4-b_cjs [k8-fastbuild]                                                      63ms
//examples/js_binary:test4-cjs-a [k8-fastbuild]                                                      76ms
//examples/js_binary:test4-mjs-a [k8-fastbuild]                                                      52ms
//examples/js_binary:test6_alt [k8-fastbuild]                                                        62ms
//examples/js_binary:test_js_binary_under_js_run_binary_cjs [k8-fastbuild]                           43ms
//examples/js_binary:test_js_binary_under_js_run_binary_no_copy_data_to_bin [k8-fastbuild]           56ms
//examples/js_binary:test_mjs [k8-fastbuild]                                                         130ms
//examples/js_binary:test_stderr [k8-fastbuild]                                                      44ms
//examples/js_lib_pkg/b:test_each_target [k8-fastbuild]                                              139ms
//examples/linked_consumer:direct [k8-fastbuild]                                                     114ms
//examples/linked_consumer:pkg [k8-fastbuild]                                                        101ms
//examples/linked_consumer:sources_test [k8-fastbuild]                                               88ms
//examples/linked_empty_node_modules:test [k8-fastbuild]                                             32ms
//examples/macro:test_esm [k8-fastbuild]                                                             566ms
//examples/npm_deps:test1 [k8-fastbuild]                                                             51ms
//examples/npm_deps:test11_cjs [k8-fastbuild]                                                        156ms
//examples/npm_deps:test6 [k8-fastbuild]                                                             168ms
//examples/npm_deps:test7_b_mjs [k8-fastbuild]                                                       150ms
//examples/npm_deps:test_peer [k8-fastbuild]                                                         184ms
//examples/stack_traces:stack_traces [k8-fastbuild]                                                  132ms
//js/private/node-patches:checked_in_compile_test [k8-fastbuild]                                     56ms
//js/private/test/create_launcher:test [k8-fastbuild]                                                177ms
//js/private/test/data:extract-js_run_binary-srcs [k8-fastbuild]                                     40ms
//js/private/test/data:from-js_library-data [k8-fastbuild]                                           110ms
//js/private/test/fixed_args:locations_test_no_expand [k8-fastbuild]                                 108ms
//js/private/test/js_binary_sh:BAZEL_BINDIR_change_directory_test [k8-fastbuild]                     72ms
//js/private/test/js_binary_sh:BAZEL_BINDIR_test [k8-fastbuild]                                      123ms
//js/private/test/js_binary_sh:BAZEL_PACKAGE_test [k8-fastbuild]                                     107ms
//js/private/test/js_binary_sh:BAZEL_TARGET_NAME_test [k8-fastbuild]                                 108ms
//js/private/test/js_binary_sh:JS_BINARY__TARGET_NAME_test [k8-fastbuild]                            86ms
//js/private/test/js_binary_sh:JS_BINARY__WORKSPACE_test [k8-fastbuild]                              107ms
//js/private/test/js_binary_sh:env_json_value [k8-fastbuild]                                         159ms
//js/private/test/js_run_devserver:js_run_devserver_test [k8-fastbuild]                              258ms
//js/private/test/node-patches:escape_node22_test [k8-fastbuild]                                     182ms
//js/private/test/node-patches:escape_node24_test [k8-fastbuild]                                     129ms
//js/private/test/node-patches:lstat_node20_cjs_test [k8-fastbuild]                                  136ms
//js/private/test/node-patches:lstat_node24_cjs_test [k8-fastbuild]                                  176ms
//js/private/test/node-patches:lstat_node24_test [k8-fastbuild]                                      176ms
//js/private/test/node-patches:lstat_nodejs_cjs_test [k8-fastbuild]                                  133ms
//js/private/test/node-patches:lstat_nodejs_test [k8-fastbuild]                                      193ms
//js/private/test/node-patches:opendir_node22_test [k8-fastbuild]                                    192ms
//js/private/test/node-patches:opendir_node24_cjs_test [k8-fastbuild]                                143ms
//js/private/test/node-patches:opendir_nodejs_test [k8-fastbuild]                                    182ms
//js/private/test/node-patches:readdir_node20_cjs_test [k8-fastbuild]                                143ms
//js/private/test/node-patches:readdir_node22_test [k8-fastbuild]                                    167ms
//js/private/test/node-patches:readdir_node24_test [k8-fastbuild]                                    228ms
//js/private/test/node-patches:readdir_nodejs_cjs_test [k8-fastbuild]                                130ms
//js/private/test/node-patches:readlink_node22_test [k8-fastbuild]                                   139ms
//js/private/test/node-patches:readlink_node24_test [k8-fastbuild]                                   237ms
//js/private/test/node-patches:readlink_nodejs_cjs_test [k8-fastbuild]                               157ms
//js/private/test/node-patches:readlink_nodejs_test [k8-fastbuild]                                   164ms
//js/private/test/node-patches:realpath_node20_test [k8-fastbuild]                                   200ms
//js/private/test/node-patches:realpath_node22_cjs_test [k8-fastbuild]                               279ms
//js/private/test/node-patches:realpath_node24_cjs_test [k8-fastbuild]                               141ms
//js/private/test/node-patches:realpath_nodejs_test [k8-fastbuild]                                   224ms
//js/private/test/node-patches:spawn_test_nodejs [k8-fastbuild]                                      978ms
//js/private/test:main_default_toolchain [k8-fastbuild]                                              112ms
//js/private/test:run_environment_info_tests_binary_env_test [k8-fastbuild]                          64ms
//js/private/test:run_environment_info_tests_test_both_subject [k8-fastbuild]                        91ms
//js/private/test:run_environment_info_tests_test_both_test [k8-fastbuild]                           65ms
//js/private/watch:watch_checked_0_test [k8-fastbuild]                                               64ms
//js/private/watch:watch_checked_1_test [k8-fastbuild]                                               79ms
//js/private/worker:worker_checked_test [k8-fastbuild]                                               79ms
//npm/private/lifecycle/min:write_min_test [k8-fastbuild]                                            64ms
//npm/private/test/npm_package:test_pkg_4 [k8-fastbuild]                                             51ms
//npm/private/test/npm_package:test_pkg_5 [k8-fastbuild]                                             40ms
//npm/private/test/subs:require_non-importers_test [k8-fastbuild]                                    151ms
//npm/private/test:bin_test [k8-fastbuild]                                                           1s
//npm/private/test:npm_auth_tests_test_1 [k8-fastbuild]                                              30ms
//npm/private/test:npm_auth_tests_test_3 [k8-fastbuild]                                              51ms
//npm/private/test:npm_auth_tests_test_5 [k8-fastbuild]                                              36ms
//npm/private/test:pkg_versions_test [k8-fastbuild]                                                  60ms
//npm/private/test:test_generated_pkg_json___rollup-binary__entry_point_tagged_manual [k8-fastbuild] 42ms
//npm/private/test:test_generated_pkg_json___rollup-target_runfiles_tagged_manual [k8-fastbuild]     49ms
//npm/private/test:test_npm_package_visibility_test_11 [k8-fastbuild]                                43ms
//npm/private/test:test_npm_package_visibility_test_12 [k8-fastbuild]                                33ms
//npm/private/test:test_npm_package_visibility_test_13 [k8-fastbuild]                                30ms
//npm/private/test:test_npm_package_visibility_test_2 [k8-fastbuild]                                 51ms
//npm/private/test:test_npm_package_visibility_test_3 [k8-fastbuild]                                 52ms
//npm/private/test:test_npm_package_visibility_test_5 [k8-fastbuild]                                 35ms
//npm/private/test:test_npmrc_test_1 [k8-fastbuild]                                                  28ms
//npm/private/test:test_npmrc_test_3 [k8-fastbuild]                                                  40ms
//npm/private/test:test_npmrc_test_5 [k8-fastbuild]                                                  31ms
//npm/private/test:test_pnpm_test_0 [k8-fastbuild]                                                   48ms
//npm/private/test:test_pnpm_test_3 [k8-fastbuild]                                                   43ms
//npm/private/test:test_pnpm_test_4 [k8-fastbuild]                                                   33ms
//npm/private/test:test_pnpm_test_7 [k8-fastbuild]                                                   37ms
//npm/private/test:test_pnpm_test_9 [k8-fastbuild]                                                   33ms
//npm/private/test:test_transitive_closure_test_0 [k8-fastbuild]                                     38ms
//npm/private/test:test_transitive_closure_test_1 [k8-fastbuild]                                     50ms
//npm/private/test:test_translate_lock_test_1 [k8-fastbuild]                                         54ms
//npm/private/test:test_translate_lock_test_2 [k8-fastbuild]                                         60ms
//npm/private/test:test_translate_lock_test_4 [k8-fastbuild]                                         29ms
//npm/private/test:test_utils_test_0 [k8-fastbuild]                                                  52ms
//npm/private/test:test_utils_test_5 [k8-fastbuild]                                                  33ms
+ 175 other targets

Bazel 9 (Test)

All tests were cache hits

275 tests (100.0%) were fully cached saving 35s.

Bazel 7 (Test)

e2e/bzlmod

All tests were cache hits

7 tests (100.0%) were fully cached saving 639ms.

Bazel 8 (Test)

e2e/bzlmod

7 test targets passed

Targets

//:check_styles [k8-fastbuild]                                                                       169ms
//:jasmine_test [k8-fastbuild]                                                                       108ms
//:node_modules_test [k8-fastbuild]                                                                  96ms
//:other_module_binary_test [k8-fastbuild]                                                           60ms
//:other_module_linked_packages [k8-fastbuild]                                                       21ms
//:other_module_run_binary_test [k8-fastbuild]                                                       47ms
//:test [k8-fastbuild]                                                                               243ms

Bazel 9 (Test)

e2e/bzlmod

All tests were cache hits

7 tests (100.0%) were fully cached saving 778ms.

Bazel 7 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Bazel 8 (Test)

e2e/git_dep_metadata

1 test target passed

Targets

//:no_git_metadata_test                                                                              26ms

Bazel 9 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Bazel 7 (Test)

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 149ms.

Bazel 8 (Test)

e2e/gyp_no_install_script

1 test target passed

Targets

//:test [k8-fastbuild]                                                                               49ms

Bazel 9 (Test)

e2e/gyp_no_install_script

All tests were cache hits

1 test (100.0%) was fully cached saving 84ms.

Bazel 7 (Test)

e2e/js_binary_workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.

Bazel 8 (Test)

e2e/js_binary_workspace

1 test target passed

Targets

//:test [k8-fastbuild]                                                                               30ms

Bazel 9 (Test)

e2e/js_binary_workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.

Bazel 7 (Test)

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.

Bazel 7 (Test)

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 227ms.

Bazel 8 (Test)

e2e/npm_link_package

2 test targets passed

Targets

//:package_store_targets_test [k8-fastbuild]                                                         20ms
//src:test [k8-fastbuild]                                                                            125ms

Bazel 9 (Test)

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 202ms.

Bazel 7 (Test)

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 269ms.

Bazel 8 (Test)

e2e/npm_link_package-esm

1 test target passed

Targets

//src:test [k8-fastbuild]                                                                            111ms

Total test execution time was 111ms. 1 test (50.0%) was fully cached saving 20ms.

Bazel 9 (Test)

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 248ms.

Bazel 7 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 251ms.

Bazel 8 (Test)

e2e/npm_link_package-rerooted

2 test targets passed

Targets

//root/src:test [k8-fastbuild]                                                                       122ms
//root:package_store_targets_test [k8-fastbuild]                                                     27ms

Bazel 9 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 231ms.

Bazel 7 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 701ms.

Bazel 8 (Test)

e2e/npm_translate_lock

3 test targets passed

Targets

//:test                                                                                              24ms
//:test_dev_filtering                                                                                78ms
//:test_prod_filtering                                                                               206ms

Bazel 9 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 455ms.

Bazel 7 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

3 tests (100.0%) were fully cached saving 268ms.

Bazel 8 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

Bazel 9 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

Bazel 7 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 132ms.

Bazel 8 (Test)

e2e/npm_translate_lock_empty

1 test target passed

Targets

//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]                                               52ms

Total test execution time was 52ms. 1 test (50.0%) was fully cached saving 62ms.

Bazel 9 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 105ms.

Bazel 7 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 33ms.

Bazel 8 (Test)

e2e/npm_translate_lock_exclude_package_contents

1 test target passed

Targets

//:test_sh                                                                                           21ms

Bazel 9 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 86ms.

Bazel 7 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 106ms.

Bazel 8 (Test)

e2e/npm_translate_lock_multi

2 test targets passed

Targets

//app1:test                                                                                          28ms
//app2:test                                                                                          26ms

Bazel 9 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 113ms.

Bazel 7 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

Bazel 8 (Test)

e2e/npm_translate_lock_partial_clone

1 test target passed

Targets

//root:test                                                                                          30ms

Bazel 9 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 38ms.

Bazel 7 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 393ms.

Bazel 8 (Test)

e2e/npm_translate_lock_replace_packages

4 test targets passed

Targets

//:node_modules_test [k8-fastbuild]                                                                  26ms
//:test [k8-fastbuild]                                                                               96ms
//:utils_test [k8-fastbuild]                                                                         87ms
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]                                               68ms

Bazel 9 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 424ms.

Bazel 7 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 94ms.

Bazel 8 (Test)

e2e/npm_translate_lock_subdir_patch

1 test target passed

Targets

//subdir:test                                                                                        54ms

Bazel 9 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 67ms.

Bazel 7 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

Bazel 8 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

Bazel 9 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

Bazel 7 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

Bazel 8 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

Bazel 9 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

Bazel 7 (Test)

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 224ms.

Bazel 8 (Test)

e2e/package_json_module

1 test target passed

Targets

//:test                                                                                              181ms

Bazel 9 (Test)

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 312ms.

Bazel 7 (Test)

e2e/patch_from_repo

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

Bazel 7 (Test)

e2e/pnpm_lockfiles

All tests were cache hits

38 tests (100.0%) were fully cached saving 4s.

Bazel 8 (Test)

e2e/pnpm_lockfiles

12 test targets passed

Targets

//cases/docusaurus-direct-peer-v9:docusaurus_direct_with_peers [k8-fastbuild]                        41ms
//cases/isaacs-cliui-v90:isaacs_cliui [k8-fastbuild]                                                 44ms
//cases/nested-peer-v9:nested_peers_targets [k8-fastbuild]                                           50ms
//cases/override-with-alias-url-v9:override-with-alias-url-v9 [k8-fastbuild]                         43ms
//cases/versionless-patch-v9:versionless_patch_targets [k8-fastbuild]                                49ms
//cases/versionless-patch-v9:versionless_patch_test [k8-fastbuild]                                   133ms
//v101:aliases-test [k8-fastbuild]                                                                   147ms
//v101:patch-test [k8-fastbuild]                                                                     102ms
//v101:targets [k8-fastbuild]                                                                        65ms
//v90:aliases-test [k8-fastbuild]                                                                    155ms
//v90:patch-test [k8-fastbuild]                                                                      100ms
//v90:targets [k8-fastbuild]                                                                         55ms

Bazel 9 (Test)

e2e/pnpm_lockfiles

All tests were cache hits

12 tests (100.0%) were fully cached saving 1s.

Bazel 7 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 840ms.

Bazel 8 (Test)

e2e/pnpm_repo_install

1 test target passed

Targets

//:pnpm_install_test                                                                                 865ms

Bazel 9 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 1s.

Bazel 7 (Test)

e2e/pnpm_version

All tests were cache hits

1 test (100.0%) was fully cached saving 56ms.

Bazel 8 (Test)

e2e/pnpm_version

Buildkite build #12197 is running...

Bazel 9 (Test)

e2e/pnpm_version

All tests were cache hits

1 test (100.0%) was fully cached saving 58ms.

Bazel 7 (Test)

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.

Bazel 8 (Test)

e2e/pnpm_workspace

14 test targets passed

Targets

//:node_test [k8-fastbuild]                                                                          257ms
//:vendored [k8-fastbuild]                                                                           66ms
//app/a:aspect_test_a_bin_test [k8-fastbuild]                                                        106ms
//app/a:npm_link_targets_node_modules_build_test [k8-fastbuild]                                      51ms
//app/a:npm_link_targets_test [k8-fastbuild]                                                         94ms
//app/a:test [k8-fastbuild]                                                                          157ms
//app/b:aliases [k8-fastbuild]                                                                       59ms
//app/b:test [k8-fastbuild]                                                                          77ms
//app/c:aspect_test_a_bin_test [k8-fastbuild]                                                        165ms
//app/c:test [k8-fastbuild]                                                                          178ms
//app/d:test [k8-fastbuild]                                                                          144ms
//lib/a:vendored [k8-fastbuild]                                                                      59ms
//lib/b:aliases [k8-fastbuild]                                                                       49ms
//lib/d:aliases [k8-fastbuild]                                                                       69ms

Bazel 9 (Test)

e2e/pnpm_workspace

All tests were cache hits

14 tests (100.0%) were fully cached saving 3s.

Bazel 7 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 355ms.

Bazel 8 (Test)

e2e/pnpm_workspace_deps

3 test targets passed

Targets

//tests:direct [k8-fastbuild]                                                                        80ms
//tests:dupes [k8-fastbuild]                                                                         79ms
//tests:pkg [k8-fastbuild]                                                                           72ms

Bazel 9 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 410ms.

Bazel 7 (Test)

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.

Bazel 8 (Test)

e2e/pnpm_workspace_rerooted

8 test targets passed

Targets

//:node_test [k8-fastbuild]                                                                          289ms
//app/a:aspect_test_a_bin_test [k8-fastbuild]                                                        146ms
//app/a:npm_link_targets_test [k8-fastbuild]                                                         73ms
//app/a:test [k8-fastbuild]                                                                          132ms
//app/b:test [k8-fastbuild]                                                                          108ms
//app/c:aspect_test_a_bin_test [k8-fastbuild]                                                        112ms
//app/c:test [k8-fastbuild]                                                                          148ms
//app/d:test [k8-fastbuild]                                                                          123ms

Total test execution time was 1s. 6 tests (42.9%) were fully cached saving 353ms.

Bazel 9 (Test)

e2e/pnpm_workspace_rerooted

All tests were cache hits

14 tests (100.0%) were fully cached saving 2s.

Bazel 7 (Test)

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 266ms.

Bazel 8 (Test)

e2e/repo_mapping

Buildkite build #12197 is running...

Bazel 9 (Test)

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 333ms.

Bazel 7 (Test)

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 179ms.

Bazel 8 (Test)

e2e/runfiles

1 test target passed

Targets

//:runfiles [k8-fastbuild]                                                                           57ms

Bazel 9 (Test)

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 92ms.

Bazel 7 (Test)

e2e/stamped_package_json

Buildkite build #12197 is running...

Bazel 8 (Test)

e2e/stamped_package_json

1 test target passed

Targets

//:stamp_test [k8-fastbuild]                                                                         24ms

Bazel 9 (Test)

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 130ms.

Bazel 7 (Test)

e2e/vendored_node

Buildkite build #12197 is running...

Bazel 8 (Test)

e2e/vendored_node

Buildkite build #12197 is running...

Bazel 9 (Test)

e2e/vendored_node

Buildkite build #12197 is running...

Bazel 7 (Test)

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

Bazel 8 (Test)

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

Bazel 9 (Test)

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

Bazel 7 (Test)

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 92ms.

Bazel 8 (Test)

e2e/verify_patches

Buildkite build #12197 is running...

Bazel 9 (Test)

e2e/verify_patches

Buildkite build #12197 is running...

Bazel 7 (Test)

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 75ms.

Bazel 8 (Test)

e2e/worker

Buildkite build #12197 is running...

Bazel 9 (Test)

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 92ms.

Buildifier Format

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd760d2fbd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T02:42:29Z

MODULE.bazel

 module(
    name = "aspect_rules_js",
    bazel_compatibility = [">=7.6.0"],
-    compatibility_level = 1,
 )


Keep module compatibility level stable

Dropping compatibility_level = 1 from the root module() declaration implicitly changes the module to compatibility level 0, which is a different Bzlmod major-compatibility track. That means dependency graphs that currently combine this module transitively with other aspect_rules_js releases at level 1 can start failing resolution due to level mismatch, even though no intentional breaking API migration was made.

Useful? React with 👍 / 👎.

wait, https://bazel.build/rules/lib/globals/module#module says default is -1 and it's deprecated, I'm very surprised.

I think we should drop it as part of v3 though, since bazel has deprecated it?

refactor: remove deprecated module(compatibility_level)

dd760d2

jbedard requested review from alexeagle and dzbarsky February 27, 2026 02:39

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

jbedard merged commit edd727b into aspect-build:main Mar 2, 2026
16 of 17 checks passed

jbedard deleted the rm-compatibility_level branch March 2, 2026 00:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: remove deprecated module(compatibility_level)#2735

refactor: remove deprecated module(compatibility_level)#2735
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:rm-compatibility_level

jbedard commented Feb 27, 2026 •

edited

Loading

Uh oh!

aspect-workflows bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Uh oh!

alexeagle Feb 27, 2026

Uh oh!

jbedard Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jbedard commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes are visible to end-users: no

Test plan

Uh oh!

aspect-workflows bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

e2e/bzlmod

e2e/bzlmod

e2e/bzlmod

e2e/git_dep_metadata

e2e/git_dep_metadata

e2e/git_dep_metadata

e2e/gyp_no_install_script

e2e/gyp_no_install_script

e2e/gyp_no_install_script

e2e/js_binary_workspace

e2e/js_binary_workspace

e2e/js_binary_workspace

e2e/js_image_oci

e2e/npm_link_package

e2e/npm_link_package

e2e/npm_link_package

e2e/npm_link_package-esm

e2e/npm_link_package-esm

e2e/npm_link_package-esm

e2e/npm_link_package-rerooted

e2e/npm_link_package-rerooted

e2e/npm_link_package-rerooted

e2e/npm_translate_lock

e2e/npm_translate_lock

e2e/npm_translate_lock

e2e/npm_translate_lock_disable_hooks

e2e/npm_translate_lock_disable_hooks

e2e/npm_translate_lock_disable_hooks

e2e/npm_translate_lock_empty

e2e/npm_translate_lock_empty

e2e/npm_translate_lock_empty

e2e/npm_translate_lock_exclude_package_contents

e2e/npm_translate_lock_exclude_package_contents

e2e/npm_translate_lock_exclude_package_contents

e2e/npm_translate_lock_multi

e2e/npm_translate_lock_multi

e2e/npm_translate_lock_multi

e2e/npm_translate_lock_partial_clone

e2e/npm_translate_lock_partial_clone

e2e/npm_translate_lock_partial_clone

e2e/npm_translate_lock_replace_packages

e2e/npm_translate_lock_replace_packages

e2e/npm_translate_lock_replace_packages

e2e/npm_translate_lock_subdir_patch

e2e/npm_translate_lock_subdir_patch

e2e/npm_translate_lock_subdir_patch

e2e/npm_translate_package_lock

e2e/npm_translate_package_lock

e2e/npm_translate_package_lock

e2e/npm_translate_yarn_lock

e2e/npm_translate_yarn_lock

e2e/npm_translate_yarn_lock

e2e/package_json_module

e2e/package_json_module

e2e/package_json_module

e2e/patch_from_repo

e2e/pnpm_lockfiles

e2e/pnpm_lockfiles

e2e/pnpm_lockfiles

e2e/pnpm_repo_install

e2e/pnpm_repo_install

e2e/pnpm_repo_install

e2e/pnpm_version

e2e/pnpm_version

e2e/pnpm_version

jbedard commented Feb 27, 2026 •

edited

Loading

aspect-workflows bot commented Feb 27, 2026 •

edited

Loading