Skip to content

Upgrade PHPStan to level 8, fix type issues, apply Rector#36

Merged
sylfabre merged 6 commits intomainfrom
fix/phpstan-rector
Mar 22, 2026
Merged

Upgrade PHPStan to level 8, fix type issues, apply Rector#36
sylfabre merged 6 commits intomainfrom
fix/phpstan-rector

Conversation

@sylfabre
Copy link
Copy Markdown
Contributor

Summary

  • Removed level: 5 override from phpstan.neon.dist (now uses default level 8)
  • Fixed 34 PHPStan errors by adding type hints and fixing type safety
  • Applied Rector fix: made data provider static
  • 3 errors baselined (entity getId() on object, pre-existing checked exceptions)

Test plan

  • Rector clean
  • PHPStan 0 errors (3 baselined)
  • PHPUnit passes (31 tests, 65 assertions)

🤖 Generated with Claude Code

@sonarqubecloud
Copy link
Copy Markdown

1 similar comment
@sonarqubecloud
Copy link
Copy Markdown

sylfabre and others added 6 commits March 22, 2026 13:58
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add setStreetName() setter to Address so ?string type is not unused
- Type FunctionalLog constructor with AbstractEntity and assert in LogFactory

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sylfabre sylfabre force-pushed the fix/phpstan-rector branch from 23b557a to 13c313d Compare March 22, 2026 12:58
@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@sylfabre sylfabre merged commit cb756bd into main Mar 22, 2026
5 of 6 checks passed
@sylfabre sylfabre deleted the fix/phpstan-rector branch March 22, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant