Chore/refactor production code 35#50
Merged
Merged
Conversation
Merge GetFirstFolderPageAsync/GetNextFolderPageAsync into single GetFolderPageAsync(string? nextLink), collapse two GetFoldersFromPagesAsync overloads into one nullable-accumulator method, inline GetDriveFoldersAsync, drop Children() helper, and add GraphClient type alias. Codify the three emerging patterns in c-sharp-code-style.md (using alias, nullable accumulator over overload pair, inline single-use wrapper) and replace the Getting root folders prose in onedrive-graph.md with concrete code examples from the refactored GraphService. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jbarden
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor some of the production code and update CLAUDE.md & rules
Type of change
Related issues / links
Closes #35
How was this tested?
Impacted areas
All areas
TDD Checklist (required)
dotnet test)How to run tests locally
Notes for reviewers