Feature/54 settings overlay shell#59
Merged
Merged
Conversation
…ceViewModel.OpenSettings (#54) References types that do not yet exist (SettingsViewModel). Compile errors expected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…dismissal (#54) - Add SettingsViewModel with Close command and Closed event - Add SettingsView with semi-transparent backdrop button (click-outside dismiss) and centered settings card with X button - Wire OpenSettings command in WorkspaceViewModel; OnSettingsClosed clears CurrentOverlay - Register SettingsViewModel as Transient in DI - Add DataTemplate for SettingsViewModel in MainWindow overlay ContentControl - Handle Escape key in MainWindow.OnKeyDown to close settings overlay - Add 4 unit tests for SettingsViewModel; add 9 unit tests for WorkspaceViewModel settings behaviour including double-subscription and stale-reference guards Closes #54 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jbarden
previously approved these changes
May 29, 2026
jbarden
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR implements the settings overlay and thus closes #54
UI has been tested manually, issues / missing code found and resolved so key AC of the issue have been confirmed