feat(search): virtualise results with ItemsRepeater + WrapLayout (#679)#680
Merged
Merged
Conversation
…#677) 4 compile errors expected — IsCapped, CappedNoticeText, CancelThumbnailLoad not yet implemented. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add IsCapped / CappedNoticeText to SyncedFileSearchViewModel; results capped at 500 with localised notice when limit is hit - Replace WrapPanel with VirtualizingStackPanel in SyncedFileSearchView so only visible containers incur layout/render cost - Defer thumbnail loading to ContainerPrepared; cancel on ContainerClearing via CancellationTokenSource in SyncedFileResultViewModel - Bump ApplicationVersion 0.26.0 → 0.27.0 Closes #677 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…#677) 500-result cap bounds render cost without requiring layout change. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace ItemsControl + WrapPanel with ItemsRepeater + WrapLayout so only visible cards are realised. Wire thumbnail load/cancel to ElementPrepared and ElementClearing. Add Avalonia.Controls.ItemsRepeater 12.0.0 package. Closes #679 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jbarden
approved these changes
Jun 22, 2026
5 tasks
astar-development-jb
pushed a commit
that referenced
this pull request
Jun 22, 2026
* feat(search): virtualise results with ItemsRepeater + WrapLayout (#679) Replace ItemsControl + WrapPanel with ItemsRepeater + WrapLayout so only visible cards are realised. Wire thumbnail load/cancel to ElementPrepared and ElementClearing. Re-applies changes reverted from PR #680. Closes #679 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(search): show loading indicator while categories fetch in search view Search view now renders immediately on navigation; the tags/categories section displays "Loading categories..." while GetDistinctTagNamesAsync is in-flight instead of flashing the "no classifications" message. IsLoadingTags and ShowNoClassificationsHint are set atomically inside dispatcher.Post so the UI never sees a transient incorrect state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ItemsControl+WrapPanelwithItemsRepeater+WrapLayout— only visible cards are realised, off-screen cards do not hold live containersItemsRepeater.ElementPrepared/ElementClearingin code-behind (replacingContainerPrepared/ContainerClearing)Avalonia.Controls.ItemsRepeaterv12.0.0 to central package management and project reference0.27.0→0.28.0(feature)Closes #679
Test plan
dotnet clean && dotnet build --no-restore— zero errors, zero warnings ✅dotnet test --no-build— 2476 passed, 0 failed, 1 skipped (pre-existing) ✅🤖 Generated with Claude Code