feat(search): show loading indicator while categories fetch#682
Merged
astar-development-jb merged 3 commits intoJun 22, 2026
Merged
Conversation
… view Search view now renders immediately on navigation; the tags/categories section displays "Loading categories..." while GetDistinctTagNamesAsync is in-flight instead of flashing the "no classifications" message. IsLoadingTags and ShowNoClassificationsHint are set atomically inside dispatcher.Post so the UI never sees a transient incorrect state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
astar-development-jb
approved these changes
Jun 22, 2026
jbarden
approved these changes
Jun 22, 2026
astar-development-jb
deleted the
feature/679-itemsrepeater-wraplayout-reapply
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsLoadingTagsandShowNoClassificationsHintobservable properties toSyncedFileSearchViewModelOnViewActivatedAsyncsetsIsLoadingTags = truesynchronously before the firstawait, then clears both flags atomically insidedispatcher.Postafter the collection is populated — no transient incorrect stateTagsLoadingText("Loading categories...") while loading, then switches to "No classifications found." only when load completes with an empty resultSearch.Tags.Loadingadded to en-GB and en-US0.28.0→0.29.0Test plan
dotnet clean && dotnet build --no-restore— zero errors, zero warningsdotnet test --no-build— 55 pass, 0 fail (5 new tests coveringIsLoadingTags,ShowNoClassificationsHint, andTagsLoadingText)🤖 Generated with Claude Code