Skip to content

fix(search): clear SelectedTags when AvailableTags is rebuilt #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astar-development-jb merged 1 commit into from
Jun 23, 2026
Merged

fix(search): clear SelectedTags when AvailableTags is rebuilt #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions ...sktop/AStar.Dev.OneDrive.Sync.Client.Tests.Unit/Search/GivenASyncedFileSearchViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,4 +547,48 @@ public async Task when_view_is_activated_with_tags_then_show_no_classifications_

sut.ShowNoClassificationsHint.ShouldBeFalse();
}

[Fact]
public async Task when_account_changes_then_selected_tags_are_cleared()
{
repository.GetDistinctTagNamesAsync(TestAccountId, Arg.Any<CancellationToken>()).Returns(["Image"]);
var sut = CreateSut();
await sut.OnViewActivatedAsync(CancellationToken.None);
sut.ToggleTagCommand.Execute("Image");

sut.SetActiveAccount(new AccountId("acc-2"));

sut.SelectedTags.ShouldBeEmpty();
}

[Fact]
public async Task when_view_is_activated_again_with_more_tags_then_selected_tags_are_cleared()
{
repository.GetDistinctTagNamesAsync(TestAccountId, Arg.Any<CancellationToken>())
.Returns(["Image"], ["Image", "Video"]);
var sut = CreateSut();
await sut.OnViewActivatedAsync(CancellationToken.None);
sut.ToggleTagCommand.Execute("Image");

await sut.OnViewActivatedAsync(CancellationToken.None);

sut.SelectedTags.ShouldBeEmpty();
}

[Fact]
public async Task when_view_is_activated_again_with_more_tags_then_search_does_not_apply_stale_selected_tags()
{
SyncedItemSearchCriteria? captured = null;
repository.SearchAsync(Arg.Do<SyncedItemSearchCriteria>(c => captured = c), Arg.Any<CancellationToken>()).Returns([]);
repository.GetDistinctTagNamesAsync(TestAccountId, Arg.Any<CancellationToken>())
.Returns(["Image"], ["Image", "Video"]);
var sut = CreateSut();
await sut.OnViewActivatedAsync(CancellationToken.None);
sut.ToggleTagCommand.Execute("Image");
await sut.OnViewActivatedAsync(CancellationToken.None);

await sut.SearchCommand.ExecuteAsync(null);

captured!.Tags.ShouldBeEmpty();
}
}
7 changes: 6 additions & 1 deletion apps/desktop/AStar.Dev.OneDrive.Sync.Client/Search/SyncedFileSearchViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,11 @@ public void SetActiveAccount(AccountId accountId)
{
activeAccountId = accountId;
cachedTagCount = 0;
dispatcher.Post(AvailableTags.Clear);
dispatcher.Post(() =>
{
AvailableTags.Clear();
SelectedTags.Clear();
});
}

/// <summary>
Expand Down Expand Up @@ -152,6 +156,7 @@ public async Task OnViewActivatedAsync(CancellationToken ct)
dispatcher.Post(() =>
{
AvailableTags.Clear();
SelectedTags.Clear();
foreach (string tag in tags)
AvailableTags.Add(tag);
IsLoadingTags = false;
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/AStar.Dev.OneDrive.Sync.Client/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"AuthorityForMicrosoftAccountsOnly": "https://login.microsoftonline.com/consumers"
},
"AStarDevOneDriveClient": {
"ApplicationVersion": "0.29.0",
"ApplicationVersion": "0.29.1",
"ApplicationName": "AStar Dev OneDrive Sync Client",
"CacheTag": 1,
"UserPreferencesPath": "astar-dev/astar-dev-onedrive-client",
Expand Down
Loading