Open
Conversation
For ease of use, when adding waypoints, if a time is left blank it is set to zero.
also started trying to make things iterative. still working on it....
Adds instructions for use with Python 2.7
Owner
There was a problem hiding this comment.
Nit: please line wrap to match the same column the initial """ starts on, and end with """ on its own line to match style elsewhere, such as here: https://github.com/astory/RankPanda/blob/master/RankPanda/RankLocation.py
(Please also do this for the rest of the docstrings)
thanks so much for moving these to docstrings though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey I got kind of bored and started playing around with Rank Panda again. One thing I found was that I was able to get it to work with python 2.7. So I updated the README to reflect that. I think the other changes I've made were fairly minor (but those were done a while ago...). But I remember finding the python 2.6 download page was kind of difficult, plus its old and people should be using 2.7.