include noexecstack hardening flag on Linux#1064
Open
jjhelmus wants to merge 1 commit intoastral-sh:mainfrom
Open
include noexecstack hardening flag on Linux#1064jjhelmus wants to merge 1 commit intoastral-sh:mainfrom
jjhelmus wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Mark the stack memory as non-executable using the '-Wl,-z,noexecstack' flag on aarch64 and x86_64 linux platforms. Other linux targets are cross-compiled, this flag is left off for the time being. closes astral-sh#1061
Contributor
Author
indygreg
approved these changes
Mar 28, 2026
Collaborator
indygreg
left a comment
There was a problem hiding this comment.
As a follow-up, please teach the ELF validation code to ensure that the stack isn't executable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the stack memory as non-executable using the '-Wl,-z,noexecstack' flag on aarch64 and x86_64 linux platforms.
Other linux targets are cross-compiled, this flag is left off for the time being.
closes #1061