Updating view handling code; pinning sqlalchemy version#89
Merged
dr-rodriguez merged 3 commits intomainfrom Feb 10, 2025
Merged
Updating view handling code; pinning sqlalchemy version#89dr-rodriguez merged 3 commits intomainfrom
dr-rodriguez merged 3 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 10 10
Lines 1116 1116
=======================================
Hits 1064 1064
Misses 52 52 ☔ View full report in Codecov by Sentry. |
dr-rodriguez
commented
Feb 10, 2025
Comment on lines
+28
to
+30
| - name: Test with pytest | ||
| run: | | ||
| pytest |
Collaborator
Author
There was a problem hiding this comment.
SQLAlchemy 2.0.38 didn't fail the install, it only failed when using the package so I've included a call to pytest.
kelle
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLAlchemy version 2.0.38, released 4 days ago, breaks how views were being handled. There is a new example of how to use them in https://github.com/sqlalchemy/sqlalchemy/wiki/Views so I've updated our code to match that. This now passes the tests.
This also pins the SQLAlchemy version to avoid similar situations in the future.