-
-
Notifications
You must be signed in to change notification settings - Fork 437
ASB-30568: Adding read_product Function to load files from s3 to memory #3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexReedy
wants to merge
28
commits into
astropy:main
Choose a base branch
from
AlexReedy:ASB-30568_read-product-function
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−0
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
1d0aba9
Initial commit for read_product function
376cc1f
adding returns for fits and asdf product types
4a7fcca
Updating read_product function
3e3b56a
Updating for cleaner asdf handling
7d8b427
Updating and adding log on failure
d45c0f7
Adding in description
beb09b5
Updating comments
1dc505e
and exception logic
587ccd6
Added in comments on package requirements for read_product functions
1bdb8a5
Updated imports to reflect only required packages
80238f6
Updating description
f883b8d
minor changes
66b4a6c
gwcs and lz4 packages do not need to be imported, they just need to b…
831baf4
Updating uri variable name to product_path be more general, as well a…
50c0ef3
Updating description
a8cb877
Updating import logic for read_product functions
a312ec2
Merge branch 'astropy:main' into ASB-30568_read-product-function
AlexReedy 18fd33c
minor format change
4f99c05
Formatting Fixes
e6ad337
Changes import logic and checking to be cleaner
29d6ad4
Formatting
548414d
Formatting fix
cfeed72
Moving into observations class
909a45a
Formatting
a2556cc
Updating CHANGES.rst to reflect updates to read_product
91f322f
Adding fsspec to imports
8dd81d2
Formatting and typo
12ab349
removing print
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does all of these really need to be checked here even as they are not directly been used? If
asdfrequires the whole list then these checks should be dealt with upstream in asdf itself.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been an ongoing question with the implementation. Required would be asdf, s3fs, fsspec for the function to work. for asdf specifically, lz4 seems to be the primary compression algorithm being used for asdf and gwcs is for the general.
I know that gwcs is in their test environment, and they also make calls to lz4 but I don't believe it's included when it's installed. I agree it should probably be upstream in asdf.