Open
Conversation
Collaborator
Author
|
@andreistefanescu .to_int() is still working with preferred local deps because we are basically in our sui repo |
andreistefanescu
left a comment
andreistefanescu
left a comment
There was a problem hiding this comment.
let's merge only the rust changes in next, and sync with @msaaltink regarding merging the move changes back in his branch.
Collaborator
Author
|
#82 rust part merge separetly |
andrii-a8c
force-pushed
the
sui-system-cherry-pick
branch
from
8d4dc8a to
0fb0e07
Compare
msaaltink
reviewed
Sep 25, 2025
Collaborator
There was a problem hiding this comment.
I don't think sender_spec and epoch_spec are needed any more with the latest prover
msaaltink
reviewed
Oct 1, 2025
|
|
||
| // === specs utils === | ||
|
|
||
| #[spec_only] |
msaaltink
reviewed
Oct 1, 2025
| #[spec_only] | ||
| use sui_system::staking_pool::activation_epoch; | ||
|
|
||
| #[spec_only] |
Collaborator
There was a problem hiding this comment.
should be test_only here, and at line 101
msaaltink
requested changes
Oct 3, 2025
Collaborator
msaaltink
left a comment
msaaltink
left a comment
There was a problem hiding this comment.
Mostly this looks fine. As noted a few spec_only should probably be test_only, and I think the "other_specs" are not needed with the latest prover versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.