Merged
Conversation
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
|
Do you think it would make sense to open this PR in the rust-lang/rust repository? :) It seems to me the intention was for this trait to exist in the standard library, but nobody has implemented it there yet. |
Contributor
Author
|
@stjepang yeah I think it does. I do think there's value in still merging the PR here though. I'll check with the lang team what they think and if they're okay with it I'll follow up with the PR to std. |
|
@stjepang @yoshuawuyts I think |
Contributor
Author
|
There's now a PR to std for this also: rust-lang/rust#65244. |
301a506 to
9eab45f
Compare
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
ghost
approved these changes
Oct 15, 2019
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
IntoFuturetrait, wihch @Nemo157 pointed out would be useful for implementing the "async builder" pattern we used when building Surf.In the RFC2394 async_await it's also stated that
awaitshould callIntoFutureunder the hood.This PR doesn't add that functionality to
await, but does have the right shape it should take, which allows people to start implementingIntoFutureso that later it will "just work".cc/ @withoutboats, is what I've said so far about
IntoFuturestill accurate? I didn't see any mentions that this had been changed in the stabilization report, so does that mean that it means this simply has not been implemented yet?Screenshot