Skip to content

feat: mark deprecated properties with @Deprecated#421

Merged
Tenischev merged 2 commits into
asyncapi:masterfrom
maltesmann:master
Nov 26, 2024
Merged

feat: mark deprecated properties with @Deprecated#421
Tenischev merged 2 commits into
asyncapi:masterfrom
maltesmann:master

Conversation

@maltesmann
Copy link
Copy Markdown
Contributor

@maltesmann maltesmann commented Nov 18, 2024

Description

See #418 for details.

Related issue(s)

Resolves #418

github-actions[bot]
github-actions Bot reviewed Nov 18, 2024
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@maltesmann maltesmann changed the title Mark deprecated properties with @Deprecated feat: Mark deprecated properties with @Deprecated Nov 18, 2024
@maltesmann maltesmann changed the title feat: Mark deprecated properties with @Deprecated feat: mark deprecated properties with @Deprecated Nov 18, 2024
@Tenischev
Copy link
Copy Markdown
Member

Tenischev commented Nov 18, 2024

Hi @maltesmann
Please update one of tests to cover this functionality. I think additional-formats.test.js could be the place, but of course you could create a new file.

@maltesmann
Copy link
Copy Markdown
Contributor Author

maltesmann commented Nov 19, 2024

Hi @Tenischev
Sure! I just added a deprecated parameter to the test you suggested. I also fixed the jinjer2 whitespace control, to not break the existing tests.

@Tenischev
Copy link
Copy Markdown
Member

Tenischev commented Nov 26, 2024

@all-contributors please add @maltesmann for code

@allcontributors allcontributors Bot mentioned this pull request Nov 26, 2024
Open
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors Bot commented Nov 26, 2024

@Tenischev

I've put up a pull request to add @maltesmann! 🎉

@Tenischev Tenischev merged commit 65589a5 into asyncapi:master Nov 26, 2024
@asyncapi-bot
Copy link
Copy Markdown
Contributor

asyncapi-bot commented Nov 26, 2024

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Tenischev Tenischev Tenischev approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Mark deprecated properties with @Deprecated

3 participants

@maltesmann @Tenischev @asyncapi-bot