You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be good to add a design rationale, in particular why we would want to design our own when crates like uom, angular_units and ang already exist.
uom in particular covers much more ground and I prefer its design in the sense that type parametricity only concerns the quantities (Length vs Angle vs Mass etc) but not the units themselves. An angle in degree and an angle in radians are the same type in uom, the unit is only seen at the boundaries when defining constants and reading a result. In this design and in angular_units (I haven't looked at ang), the way the type of the sum of degree and radian angles is chosen feels arbitrary.
Defining conversion functions like Degree::to_radians may not scale too well if we want to generalize to quantities like length etc which have many common units.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add strongly typed angle units (Degrees and Radians) with conversions and arithmetic