fix: replace deprecated context.getFilename() for ESLint 10 compatibility#105
Open
roli-lpci wants to merge 1 commit into
Open
fix: replace deprecated context.getFilename() for ESLint 10 compatibility#105roli-lpci wants to merge 1 commit into
roli-lpci wants to merge 1 commit into
Conversation
ESLint 10 removed `context.getFilename()` in favor of `context.filename`. Use nullish coalescing fallback to support both ESLint 10+ and older versions. Fixes atfzl#104 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the deprecated
context.getFilename()call withcontext.filename ?? context.getFilename()inlib/core/index.js.Why
context.getFilename()was deprecated in ESLint v8.40 and removed in ESLint v10, causingTypeError: context.getFilename is not a function. Thecontext.filenameproperty has been available since v8.40, and the??fallback preserves backward compatibility with older versions.Reference: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/
Testing
All 71 existing tests pass.
Fixes #104