Set the cache headers for static resources#38
Open
megawac wants to merge 2 commits intoatheme-legacy:masterfrom
Open
Set the cache headers for static resources#38megawac wants to merge 2 commits intoatheme-legacy:masterfrom
megawac wants to merge 2 commits intoatheme-legacy:masterfrom
Conversation
30 day default
Contributor
|
I'm worried that caching for 30 days is a bit long (mostly because this includes the JavaScript as it is 'static content'). I'll think about this pull request a bit more. |
Author
|
Ya, honestly I didn't think too much in to the period and probably add an option to set it in the config file. Would you like me to patch without the debug statement and an option in the config for the period. Edit also don't the JS and css files get given a random hash suffix on compile? So that shouldn't be a concern |
Add an option to set the duration of the cache. 30 day default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the cache headers on static resources for 30 days
Wrote this for my fork; figured you guys may be interested in this change
Edit - just noticed I forgot to remove a debug statement in caching - my bad