For the merge-languages branch: Fix language-java package#441
Merged
aminya merged 2 commits intoatom-community:merge-languagesfrom Jul 8, 2022
Merged
For the merge-languages branch: Fix language-java package#441aminya merged 2 commits intoatom-community:merge-languagesfrom
aminya merged 2 commits intoatom-community:merge-languagesfrom
Conversation
Member
Author
|
There is a tangentially related commit on my branch that refreshes all the package-lock.json files in the I can remove that if preferred. It hopefully makes no difference. (I just vaguely recall we had to do this once to make the cache hash of the |
aminya
approved these changes
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
In PR #416, the grammar file
packages/language-java/grammars/tree-sitter-java.csonis out of date now thattree-sitter-java-devpackage was replaced bytree-sitter-java.Background info
@mauricioszabo pointed out in Discord that there is something wrong with the
language-javapackage in PR #416 's branch.I investigated and... found a different issue affecting the same package, apparently.
The parser package was updated from the
tree-sitter-java-devpackage to the newertree-sitter-javapackage (no-devin the name).Description of the Change
In the grammar file
packages/language-java/grammars/tree-sitter-java.cson, updated theparser:field to match the updatedtree-sitter-javapackage, whichlanguage-javawas updated to depend on in PR #416 's branch.(Instead of the old
tree-sitter-java-devpackage from before.)Alternate Designs
❌
Possible Drawbacks
❌
Verification Process
Prevented this error for me when I built locally:
Release Notes
N/A