This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
|
@50Wliu Thanks for opening this ⚡️ LGTM. I couldn't notice any delay even with a larger project and slow computer where I noticed the issue this fixes! 🚢 if you are fine with the drawback! |
|
This issue has been driving me crazy - would love to have this fixed! Any reason it can't be merged? Seems like a slam dunk—straightforward code and small scope of changes. |
Contributor
Author
|
Forgot about this PR. Let me revisit it in the next few days and see if I can remember my logic here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
After a reindex completes, all the items in the select list get regenerated. If someone had a file selected, the refresh would cause the selection to jump back to the first element. This PR fixes that by manually re-selecting the previous file after the reindex completes.
Alternate Designs
I hope there's an alternate design; this one didn't come out that pretty.
Benefits
Selection will not unexpectedly change after a reindex completes.
Possible Drawbacks
The for loop I added creates some delay, especially for larger projects since it loops through every single file.
Applicable Issues
Fixes #210
/cc @Ben3eeE