This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
Contributor
|
I am extremely biased here, but I came to Atom directly from Sublime, so I favor the cmd-shift-p shortcut (although I came to Sublime from TextMate, so I was used to cmd-t before... shrugs). |
Contributor
|
One other data point is that the GitHub website uses the |
|
Ping? Let's move this forward one way or the other to free up a keybinding! |
Contributor
|
I'm honestly reluctant to remove either binding, but |
|
👍 💯 The However I agree that we'd need to remove
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will require a docs update, but opening for discussion as this came up in chat with @bolinfest.
Good keybindings are precious and rare, and we don't have to hew perfectly to sublime for new users. I understand that users can rebind commands as necessary, but as most users will likely stick to the defaults, I think we should pick one binding for the fuzzy finder and stick with it. I personally remapped cmd-p to the command palette literally the first day I started using Atom so I prefer to keep cmd-t but I know that's totally subjective and could be argued into doing this the other way.
cc: @bolinfest , @atom/core