Conversation
brennens
approved these changes
Apr 30, 2025
Tr3yb0
reviewed
Apr 30, 2025
|
|
||
| let iframeElement = document.createElement('iframe') | ||
| iframeElement.setAttribute('allow', 'web-share') | ||
| const productType = config.product || 'Transact' |
Contributor
There was a problem hiding this comment.
Should probably || config.operation in the productType first
brennens
approved these changes
May 2, 2025
|
Won't this only work for the legacy config, and not the one that uses tasks[i].operation or tasks[i].product? The snapshot is showing what it'll look like for anyone using the latest config syntax: "Atomic Atomic Interface" That seems weird to me to (1) fall back to repeating "Atomic" twice in the phrase and (2) to have all of the latest config syntax fall back. |
wilsonparson
previously requested changes
May 5, 2025
wilsonparson
left a comment
There was a problem hiding this comment.
Unless I'm misunderstanding, this needs some work to support the latest config that we tell people to use in the docs, as well as the fall back to saying "Atomic Atomic Interface."
brennens
approved these changes
Jun 12, 2025
Reviewed with Brennen and fix Wilsons prior feedback
sean-hill
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear Link
https://linear.app/atomicbuilt/issue/DD-1752/iframe-descriptive-title
Type of change
Checklist: