Skip to content

fix: use ios sdk version to fetch frameworks#126

Merged
brax10ward merged 1 commit into
masterfrom
braxton/fix-release-dynamic-workflow
Apr 29, 2026
Merged

fix: use ios sdk version to fetch frameworks#126
brax10ward merged 1 commit into
masterfrom
braxton/fix-release-dynamic-workflow

Conversation

@brax10ward
Copy link
Copy Markdown
Contributor

@brax10ward brax10ward commented Apr 29, 2026

Linear Link

https://linear.app/atomicbuilt/issue/SDK-557/expo-build-issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which cleans up code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change impacts security

Checklist:

  • New and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have tested on a physical iOS device and Android device
  • I have added tests that prove my fix is effective or that my feature works
  • I have followed the Code Review and Code Review Security guidelines
  • I have checked my code against flaws from the OWASP Top 10
    • A01:2021-Broken Access Control
    • A02:2021-Cryptographic Failures
    • A03:2021-Injection
    • A04:2021-Insecure Design
    • A05:2021-Security Misconfiguration
    • A06:2021-Vulnerable and Outdated Components
    • A07:2021-Identification and Authentication Failures
    • A08:2021-Software and Data Integrity Failures
    • A09:2021-Security Logging and Monitoring Failures
    • A10:2021-Server-Side Request Forgery

# Use just the first dot-segment as the dist-tag (e.g. beta.1 → beta)
DIST_TAG="${PRERELEASE_LABEL%%.*}"
echo "Publishing prerelease $VERSION under dist-tag '$DIST_TAG'"
npm publish --access public --tag "$DIST_TAG"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use this for any kind of alternate version now

@brax10ward brax10ward requested a review from eriksargent April 29, 2026 16:01
@brax10ward brax10ward merged commit 64b689d into master Apr 29, 2026
5 checks passed
@brax10ward brax10ward deleted the braxton/fix-release-dynamic-workflow branch April 29, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants