Fix data race in keyboard.Listen() and unit tests, enable race detection#7
Open
gheinrich-dd wants to merge 1 commit intoatomicgo:mainfrom
Open
Fix data race in keyboard.Listen() and unit tests, enable race detection#7gheinrich-dd wants to merge 1 commit intoatomicgo:mainfrom
gheinrich-dd wants to merge 1 commit intoatomicgo:mainfrom
Conversation
Author
|
If bumping to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There's currently a data race as described here. This makes it hard to enable data race detection for projects using this package. I'm implementing a possible solution using the
atomic.Boolwrapper and enabling race detection via-racefor go tests. I also had to wrap appending to the slice in a unit test with a lock to fix another data race issue. One caveat of this solution is that usingatomic.Boolrequires a minimum go version of 1.19.