Add CodeQL query to check allocations do not exceed ensure_free#2101
Open
pguyot wants to merge 1 commit intoatomvm:mainfrom
Open
Add CodeQL query to check allocations do not exceed ensure_free#2101pguyot wants to merge 1 commit intoatomvm:mainfrom
pguyot wants to merge 1 commit intoatomvm:mainfrom
Conversation
eaf5720 to
3b69c44
Compare
3b69c44 to
6e79c18
Compare
bettio
requested changes
Feb 16, 2026
6e79c18 to
c90f8c9
Compare
schnittchen
reviewed
Feb 22, 2026
schnittchen
reviewed
Feb 22, 2026
The query also checks redundant ensure_free calls, i.e. calls followed by another call with no allocation in between. Fix errors found by the query: - Add a missing ensure_free in esp32 `dac_driver.c` - Fix and simplify allocation in `adc_driver.c` (fix misplaced parenthesis bug and merge two ensure_free calls into one) - Remove redundant ensure_free calls in `otp_ssl.c` (left over from removal of `enif_make_resource` which used to do its own ensure_free) - Remove a redundant ensure_free call in `nif_erlang_fun_to_list` Signed-off-by: Paul Guyot <pguyot@kallisys.net>
c90f8c9 to
aea7bf1
Compare
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query also checks redundant ensure_free calls, i.e. calls
followed by another call with no allocation in between.
Fix errors found by the query:
dac_driver.cadc_driver.c(fix misplacedparenthesis bug and merge two ensure_free calls into one)
otp_ssl.c(left overfrom removal of
enif_make_resourcewhich used to do its ownensure_free)
nif_erlang_fun_to_listThese changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later