Skip to content

Fix: benign gen_server start race crash reports #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petermm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: benign gen_server start race crash reports #2172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions libs/estdlib/src/gen_server.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,22 +125,22 @@ init_it(Starter, Name, Module, Args, Options) ->
init_it(Starter, Module, Args, Options)
catch
error:badarg:S ->
ErrorT =
case whereis(Name) of
undefined ->
badarg;
Pid when is_pid(Pid) ->
{already_started, Pid}
end,
crash_report(
io_lib:format("gen_server:init_it/5: Error initializing module ~p under name ~p", [
Module, Name
]),
Starter,
ErrorT,
S
),
proc_lib:init_ack(Starter, {error, ErrorT})
case whereis(Name) of
undefined ->
crash_report(
io_lib:format(
"gen_server:init_it/5: Error initializing module ~p under name ~p", [
Module, Name
]
),
Starter,
badarg,
S
),
proc_lib:init_ack(Starter, {error, badarg});
Pid when is_pid(Pid) ->
proc_lib:init_ack(Starter, {error, {already_started, Pid}})
end
end.

init_it(Starter, Module, Args, Options) ->
Expand Down
Loading