PTY event loop: connect all session components#49
Merged
andreahlert merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
Event loop (session/event_loop.rs): - stdin reader: raw bytes → KeyEvent → PopupState → forward/show/erase - PTY reader: blocking thread → channel → OscParser → strip OSC + passthrough - PTY writer: channel → blocking write to master fd - Terminal writer: blocking thread with stdout lock → passthrough + popup - SIGWINCH handler: resize PTY + update popup cols - Escape timeout: 10ms disambiguates standalone ESC from sequences - Accept: Ctrl-A + Ctrl-K + retype via PTY master (readline-compatible) Session entry (session/mod.rs): - Auto-starts daemon if not running - Writes integration script to temp file - Spawns shell via PTY with --rcfile - Enables raw mode with scopeguard restoration - Runs event loop via tokio runtime - Cleans up temp files on exit popup.rs: Made popup_lines field pub for event loop access Closes #45 Signed-off-by: André Ahlert <andre@aex.partners>
- Await stdin_task, sigwinch_task, pty_writer_task after abort() to ensure they've stopped before master fd is closed - Remove mem::forget(master): OwnedFd drop is the intended single close point (both threads already mem::forget their File copies) - Prevents use-after-close on master fd during SIGWINCH or mid-write Signed-off-by: André Ahlert <andre@aex.partners>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The core event loop that connects PTY, keys, OSC, popup, and async IPC into a working session.
tabra sessionnow spawns a real shell inside a PTY wrapperIssues
Closes #45
Test plan
cargo run -- sessiondrops into a working bash shell