tests: better parameter-based testing

R/central-tendency.R

@@ -1,5 +1,4 @@
 # TODO:
-# - Add tests
 # - Add description
 
 #' Geometric Mean (GM)

R/variability.R

@@ -1,5 +1,4 @@
 # TODO:
-# - Add tests
 # - Add description
 
 #' Coefficient of Variation (Cv)
@@ -52,13 +51,17 @@ cv.data.frame <- function(
   )
 }
 
+# TODO:
+# Rewrite in C++
+
 #' @rdname cv
 #' @export
 cv_vec <- function(
   truth,
   na_rm = TRUE,
   ...
 ) {
+  # ugly, might not need
   yardstick::check_numeric_metric(truth, truth, case_weights = NULL)
 
   if (na_rm) {

tests/testthat.R

@@ -7,6 +7,7 @@
 # * https://testthat.r-lib.org/articles/special-files.html
 
 library(testthat)
+library(checkmate)
 library(tidyhydro)
 
 test_check("tidyhydro")

tests/testthat/test-kge.R

@@ -81,3 +81,12 @@ test_that("Internal function works as expected", {
       kge_cpp(ex_dat$obs, ex_dat$pred, na_rm = TRUE, version = "2012")
   )
 })
+
+test_that("Negative values are not allowed in kgelog", {
+  x <- rnorm(100)
+  y <- rnorm(100)
+
+  expect_error(kgelog_vec(x, y))
+  expect_error(kgelog_hi_vec(x, y))
+  expect_error(kgelog_low_vec(x, y))
+})

tests/testthat/test-measures.R

@@ -0,0 +1,5 @@
+test_that("Negative values are not allowed in GM", {
+  x <- rnorm(100)
+
+  expect_error(gm_vec(x))
+})