Fix receipt cull logic and bytes edge case.#20
Merged
attermann merged 3 commits intoattermann:masterfrom Feb 24, 2026
Merged
Conversation
Contributor
DanBeard
commented
Feb 10, 2026
DanBeard
commented
- Added check to truncate odd hex string so it doesn't read past buffer.
- Fixed receipt cull logic so it will remove receipts to cull from _receipts list. This was causing a memory leak.
- Added unit tests to test the fixes (with Claude code. I can remove these if you don't want to touch LLM code)
- Bytes::assignHex/appendHex: truncate to even length before parsing to prevent reading past buffer on odd-length hex strings - Bytes::mid(): fix off-by-one in bounds check (>= vs >) - Transport: fix receipt culling loop iterating wrong list, which caused stale receipts to accumulate instead of being removed Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests for Bytes::assignHex, appendHex, mid() edge cases, and Transport receipt culling logic. 18 test cases covering the bugs fixed in the previous commit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Disabled `test_receipt_timeout_callback` test which is currently failing.
Owner
|
Nice catches @DanBeard! Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.