Pin attitude/phpx to ^0.4.1, simplify install to a single require#15
Merged
Conversation
Upstream now tags releases (v0.2.1–v0.4.1), so the dev-main pin is no longer needed. v0.4.1 brings renderer attribute fixes, compiler backslash escaping, and parser hardening. The recompiled todo example only changes quote style: static attributes now emit single-quoted PHP strings (the compiler escaping fix in attitude/phpx#38). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
With tags on both packages, consumers only require attitude/phpx-server — attitude/phpx resolves transitively as a stable release (verified in a scratch consumer project). The dual VCS repository entries remain required until Packagist. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Upstream
attitude/phpxnow tags releases (v0.2.1–v0.4.1). Requiringdev-mainis no longer necessary and left consumers exposed to unreviewed upstream changes on everycomposer update.What
composer.json:attitude/phpxdev-main→^0.4.1(renderer attribute fixes, compiler backslash escaping, parser hardening).examples/todo/src/components.phpwith the v0.4.1 compiler. The diff is quote style only: static attributes now emit single-quoted PHP strings (upstream escaping fix fix(compiler): escape backslashes in text, attribute values, and template literals phpx#38). Verified no semantic changes.require—attitude/phpxnow resolves transitively as a stable release. Verified in a scratch consumer project. Both VCSrepositoriesentries remain until Packagist. Net −2 lines in each file.Verification
composer test: 39 tests, 94 assertions, green (1 pre-existing skip) — before and after recompile.composer analyse: PHPStan clean.attitude/phpx-serverrequired resolvesattitude/phpx v0.4.1transitively.The install snippet references
^0.1.1, sov0.1.1should be tagged right after this merges.🤖 Generated with Claude Code