new CassetteTape API

[sh95014]

• deprecate TapeInfo.size and pos, replace with duration and position in milliseconds
• add playbackRate (for potential future enhancement of accelerated tape loading)
• add playbackRateChangeCallback to avoid client polling
• remove myIsPlaying since it is redundant with myBaseCycles != -1
• update sdlsettings for new API

notes:

• I deprecated instead of deleting size and pos to avoid breaking any non-sa2 clients
• I used a callback to avoid having to touch FrameBase

see #338

[audetto]

Do we really need the deprecation? Who is using it?

[audetto]

playbackRateChangeCallback is only called with 0 or 1. Is a double the real best argument?

[sh95014]

Re deprecation: I just wasn’t sure if any of your other frontends are using it. If it’s just sa2 then they can be deleted.

Re playbackRate: If we somehow implement accelerated tape loading in the future, the playbackRate might not be an integer. Probably overthinking it.

[audetto]

OK, just remove the deprecated things.

[sh95014]

@audetto removed the deprecated fields

[audetto]

I am not sure I understand github's way to comment on lines. So i repeat theme here

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"

why we need this?

and

void (*playbackRateChangeCallback)(double playbackRate) = 0;

can we be a bit more modern with a std::function<void(double)> ?

[sh95014]

1. Disabling the deprecation warning was for when I was trying to not break any other frontends, I'll get rid of it.
2. I'll revise using std::function.

[sh95014]

@audetto updated as requested.

[audetto]

Since we are making it more readable, I'd change std::optional<int64_t> myBaseCycles;

[sh95014]

@audetto done!