ci: stop running the verify suite on main pushes#48
Merged
Conversation
CI and Release both triggered on `push: [main]`, so every merge ran the types/test/lint/knip suite twice. Release already self-verifies before semantic-release + deploy (release.yml), so the CI run on main was pure duplication — a failure there would block the deploy via Release anyway. Keep CI on `pull_request` (the branch-protection gate; Release never runs on PRs) and let Release own main-branch verification. No workflow_run coupling — Release stays self-contained so a deploy never rides on an external green signal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove
push: [main]fromci.ymlso the verify suite (types/test/lint/knip) no longer runs twice on every merge tomain.Why
Both CI and Release triggered on
push: [main], so each merge ran the same four checks twice. Release already self-verifies beforesemantic-release+ deploy (release.yml), and aborts the deploy if any check fails — so the CI run onmainwas pure duplication with no added safety.After this change:
pull_request).mainpushes → only Release runs, self-verifies, then releases + deploys.No
workflow_runcoupling: Release stays self-contained, so a deploy never rides on an external green signal.Trade-off
The
maincommit no longer gets a fast, independent CI check separate from Release (which is slower and serialized viaconcurrency: group: release). Thin edge case; acceptable given Release's own verification.🤖 Generated with Claude Code