fix(navigation-plan): add query string from redirect instruction

[MartyBoi]

See issue: https://github.com/aurelia/router/issues/639

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[bigopon]

@MartyBoi It doesn't seem we can simply append the redirect location. There're cases where things would override each other, and there is an issue with redirect with dynamic part in the URL too.

Would need @davismj to chime in

[rmja]

This seems like a reasonable and non breaking change. Could it be merged?

[rmja]

I would really appreciate if a maintainer would look at this PR. It seems really simple and I have used it for a long time now in a big app without any issues.
ping @bigopon

[bigopon]

@rmja there' concerns stated in my comments above #643 (comment) and the linked issues.
I don't think we can simply merge this yet. And for the very least, we should have a failing test, can you help with that? I can then help proceed this forward faster.

[rmja]

@bigopon Thanks for getting back. There is a very simple example in the issue #667.
Basically, if a route is configured like { route: "does-not-work", redirect: "/dashboard?autoselect=true"; }, then the parameter autoselect is not passed on as a parameter to dashboard.

[rmja]

How do we proceed with this?

[rmja]

@bigopon ping..

[bigopon]

Thanks @rmja , it's been a bit difficult to proceed with this for I haven't had time to focus on v1 repos (there been a few queued items), and this repo specifically needs special setup work refactoring to make all future work fast/easy. Will keep this in mind and act as soon as I can.