Exclude third-party clients by default; supersede AUTH0_EXCLUDE_THIRD__PARTY_CLIENTS with AUTH0_INCLUDE_THIRD_PARTY_CLIENTS configuration option#1225
Draft
mgyarmathy wants to merge 2 commits intoauth0:masterfrom
Conversation
…_PARTY_CLIENTS with AUTH0_INCLUDE_THIRD_PARTY_CLIENTS configuration option
mgyarmathy
changed the title
AUTH0_EXCLUDE_THIRD__PARTY_CLIENTS with AUTH0_INCLUDE_THIRD_PARTY_CLIENTS configuration option
Contributor
|
Thank you for your contribution! We are keeping this PR in draft for now, until the next 9.x.x phase is planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
(This PR is a follow-up to @kushalshit27's recommendation in #1212.)
auth0-deploy-clinow excludes third-party clients by default, but allows users to opt into including them with theAUTH0_INCLUDE_THIRD_PARTY_CLIENTSconfiguration option.This PR introduces a breaking change to users who depend on the current default inclusion behavior of third-party clients, so releasing this warrants a major version bump to 9.x.x.
🔬 Testing
Prior tests for the former
AUTH0_EXCLUDE_THIRD__PARTY_CLIENTSconfiguration option have been updated to the opposite behavior to testAUTH0_INCLUDE_THIRD_PARTY_CLIENTS.📝 Checklist