Skip to content

feat(core): passkey management core changes#304

Open
NaveenChand755 wants to merge 8 commits into
mainfrom
feat/passkeys-core-changes
Open

feat(core): passkey management core changes#304
NaveenChand755 wants to merge 8 commits into
mainfrom
feat/passkeys-core-changes

Conversation

@NaveenChand755
Copy link
Copy Markdown
Contributor

@NaveenChand755 NaveenChand755 commented May 27, 2026

Summary

Adds core passkey infrastructure (types, WebAuthn utils, i18n) to the my-account package. Also cleans up redundant MFA exports from index.ts and user-passkey-service hook

Why

  • React passkey components need these building blocks before they can be built
  • Follows the same pattern MFA uses for consistency
  • Duplicate exports were dead weight
  • adds user passkey service hook required for the user passkey hook

What

  • Passkey service layer — SDK types, React Query keys, WebAuthn browser utils
  • Passkey i18n — English strings + PasskeyMessages interface for consumer overrides
  • Removed duplicate MFA named exports already covered by export *

Packages

  • packages/core
  • packages/react
  • examples

References

Testing

How can this be verified? Note anything intentionally not covered by tests and why.

  • This change adds unit test coverage
  • Tested for both SPA and RWA flows, all example apps working
  • All existing and new tests complete without errors

Checklist

  • Breaking change
  • Requires docs update
  • Backward compatible

Contributing

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (aecf241) to head (07eb204).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   89.47%   89.55%   +0.08%     
==========================================
  Files         156      159       +3     
  Lines       13070    13178     +108     
  Branches     1419     1827     +408     
==========================================
+ Hits        11694    11802     +108     
  Misses       1376     1376              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NaveenChand755 NaveenChand755 force-pushed the feat/passkeys-core-changes branch from 47f6bc2 to 07d26c8 Compare May 28, 2026 11:01
Comment thread packages/react/src/hooks/my-account/shared/services/use-user-passkey-service.ts Outdated
Comment thread packages/core/src/services/my-account/passkey/passkey-utils.ts
Comment thread packages/core/src/services/my-account/passkey/passkey-utils.ts
Comment thread packages/core/src/services/my-account/passkey/__tests__/passkey-utils.test.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants