refactor(react): sso-provider-create hook service separation#314
Draft
harishsundar-okta wants to merge 1 commit into
Draft
refactor(react): sso-provider-create hook service separation#314harishsundar-okta wants to merge 1 commit into
harishsundar-okta wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
========================================
Coverage 89.47% 89.47%
========================================
Files 156 156
Lines 13070 13074 +4
Branches 1419 1805 +386
========================================
+ Hits 11694 11698 +4
Misses 1376 1376 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the useSsoProviderCreate hook to follow the two-layer hook architecture (service + public hook).
Why
The SSO provider create hooks did not follow the established hook architecture pattern where a single public hook consumes an internal service hook. Previously, the logic was split across use-sso-provider-create (service/API) and use-sso-provider-create-logic (UI state), which is the inverse of the agreed-upon convention.
What
Packages
packages/corepackages/reactexamplesReferences
Testing
How can this be verified? Note anything intentionally not covered by tests and why.
Checklist
Contributing