Add configurable SSLSocketFactory support for HTTPS connections#252
Closed
tanya732 wants to merge 4 commits into
Closed
Add configurable SSLSocketFactory support for HTTPS connections#252tanya732 wants to merge 4 commits into
tanya732 wants to merge 4 commits into
Conversation
rmad17
approved these changes
Apr 21, 2026
rmad17
left a comment
rmad17
left a comment
There was a problem hiding this comment.
LGTM!
Note: We should share a communication within the team that to support Java 8 for our users we need to allow support for TLS 1 and 1.1 which are deprecated versions.
Contributor
Author
|
Closing in favor of #256, which introduces a pluggable JwksHttpClient interface that addresses this use case (along with others) in a more flexible way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SSLSocketFactorysupport toUrlJwkProviderandJwkProviderBuilder, allowing users to configure TLS version, custom trust stores, and mutual TLS (mTLS) for HTTPS connections to the JWKS endpointgoogleapis/google-http-java-client) forURLConnection-based SSL configuration