fix: resolve EXC_BAD_ACCESS crash caused by Int32 type mismatch in native bridge#1421
Merged
subhankarmaiti merged 1 commit intomasterfrom Dec 18, 2025
Merged
Conversation
|
@subhankarmaiti were you able to replicate the crash? |
Contributor
Author
|
Yes @NandanPrabhu , and after this change it got fixed |
sanchitmehtagit
approved these changes
Dec 18, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes an EXC_BAD_ACCESS crash on iOS that occurred after upgrading to React Native 0.83.0, caused by a type mismatch in the native bridge between JavaScript's number type and Objective-C's NSInteger type.
- Changed iOS native bridge parameter types from
NSIntegertodoubleto match JavaScript's number type - Added explicit
(NSInteger)casts when passing values to Swift methods that expectInt - Aligned iOS implementation with Android, which already uses
Doublefor these parameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
EXC_BAD_ACCESS (code=1, address=0x20)crash on iOS introduced in #1414 when upgrading to React Native 0.83.0.Changes Made
iOS Native Bridge (
ios/A0Auth0.mm)NSIntegertodoubleto match JavaScript's number type(NSInteger)casts when passing values to Swift methodsminTTLingetCredentials,hasValidCredentials,getApiCredentialswebAuthmethod to usedoubleValueinstead ofintegerValueformaxAge,leeway, andsafariViewControllerPresentationStyleAndroid
Doubletype correctly🧪 Testing
🔗 Related