Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
authier-vault-web | cc3571a | Commit Preview URL Branch Preview URL |
Apr 14 2026, 07:53 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
isElementVisibleInViewportinweb-extension/src/content-script/isElementInViewport.tswhich requires the element to be connected, have client rects, not be hidden (display:none,visibility:hidden/collapse,opacity:0, orhiddenattribute), and be inside the viewport, and improvedisHiddenaccordingly.autofillValueIntoInputinweb-extension/src/content-script/autofill.tsto skip autofill when an input is not visible in the viewport by usingisElementVisibleInViewportand log the skip.autofill.tsto only dispatch submit when the form and all autofilled inputs are visible in the viewport; otherwise the submit is skipped and a log entry is emitted.web-extension/src/content-script/isElementInViewport.spec.tsto cover viewport and visibility helper behavior.Testing
cd web-extension && pnpm vitest run src/content-script/isElementInViewport.spec.tsand the tests passed: 1 test file, 5 tests passed.pnpm --dir web-extension vitest run ...invocation failed due to the workspace invocation; the correct command above was used to run the tests successfully.)Codex Task