feat: support permission type annotations (use typechecking)#21
Merged
Conversation
Parse the optional return-type annotation on permissions (`permission view: user | group = ...`) introduced by the SpiceDB `use typechecking` flag. Previously any annotated permission failed to parse, which — in editor tooling — disabled go-to-definition and semantic highlighting for the entire schema. - dsl.ts: add an optional `: type | type` annotation to the permission grammar, restricted to plain type identifiers to match the SpiceDB parser. Expose it as `ParsedPermission.annotatedTypes` (a TypeExpr of TypeRefs) and walk it in findReferenceNode and mapParseNodes so go-to-definition resolves on annotation types. - resolution.ts: include annotation type refs in resolvedReferences() so they resolve and highlight like relation types. - Tests for the AST, the error cases mirrored from the SpiceDB parser fixtures, findReferenceNode, and the resolver.
josephschorr
enabled auto-merge (squash)
July 15, 2026 18:07
samkim
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse the optional return-type annotation on permissions (
permission view: user | group = ...) introduced by the SpiceDBuse typecheckingflag. Previously any annotated permission failed to parse, which — in editor tooling — disabled go-to-definition and semantic highlighting for the entire schema.: type | typeannotation to the permission grammar, restricted to plain type identifiers to match the SpiceDB parser. Expose it asParsedPermission.annotatedTypes(a TypeExpr of TypeRefs) and walk it in findReferenceNode and mapParseNodes so go-to-definition resolves on annotation types.