fixes to secondary dispatch hedger#2283
Merged
josephschorr merged 18 commits intomainfrom Mar 24, 2025
Merged
Conversation
3ff5a83 to
9745043
Compare
fc10092 to
ae34da2
Compare
3f955ec to
38a8e94
Compare
vendors influxdata/tdigest#32 for the purpose of validating the functionality without the panic. We will likely follow up by replacing the library as this tdigest does not seem to be maintained anymore.
…ore fine-grained and cancel sooner
the rationale is that we want to make the wait number smaller and not focus on the tail latencies of secondary.
we can now see how many primary dispatches get canceled with the metric. In our testing environment, a p90 gave us 32% cancelation for checks, and roughly 61% for lookups. Let's test with p95
38a8e94 to
6cc7ad9
Compare
josephschorr
approved these changes
Mar 24, 2025
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DispatchLookupSubjectsResponse