Travis CI: Detect Python syntax errors and undefined names#63
Closed
cclauss wants to merge 8 commits intoautocracy:masterfrom
Closed
Travis CI: Detect Python syntax errors and undefined names#63cclauss wants to merge 8 commits intoautocracy:masterfrom
cclauss wants to merge 8 commits intoautocracy:masterfrom
Conversation
Legacy __print__ statements are syntax errors in Python 3 but __print()__ function works as expected in both Python 2 and Python 3. There are 250 days until Python 2 end of life.
autocracy
force-pushed
the
patch-1
branch
2 times, most recently
from
e60ce66 to
f835bc6
Compare
Owner
|
Can you properly rebase this commit? I'd love to get a clean merge. |
Contributor
Author
|
Ready for your review. |
So give pip all dependencies in a single command.
Owner
|
The merge commit I did at the end doesn't make for a clean application. They actually have to be rebased similar to what I did in #70 As for the additional commits, I'm planning on keeping the tests for Python 2.7 and 3.4 until breaking them becomes a problem. I'm going to rework travis.yaml as in #71 to still test 3.4 in xenial, but to also test the newer distribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://flake8.pycqa.org
Follow Python porting best practice: use feature detection instead of version detection
Use print() function in both Python 2 and Python 3