-
Notifications
You must be signed in to change notification settings - Fork 13
dev #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev #324
Changes from all commits
15c9a2c
67541ab
26a65a6
9ff6c06
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,11 @@ jobs: | |
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| # For workflow_call: checkout the version tag created by release.yml | ||
| # For tag push: checkout the pushed tag (github.ref) | ||
| # For workflow_dispatch: checkout the specified tag or default branch | ||
| ref: ${{ inputs.version && format('v{0}', inputs.version) || github.ref }} | ||
|
|
||
| - name: Set zig suffix for cache key | ||
| if: matrix.use-zigbuild | ||
|
|
@@ -405,7 +410,10 @@ jobs: | |
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| with: | ||
| # Checkout the correct version tag (same as build jobs) | ||
| ref: ${{ inputs.version && format('v{0}', inputs.version) || github.ref }} | ||
|
Comment on lines
412
to
+415
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The publish job’s checkout uses the same Useful? React with 👍 / 👎. |
||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
|
|
@@ -525,11 +533,17 @@ jobs: | |
| id: pkg | ||
| run: | | ||
| NAME=$(node -e "console.log(require('./npx-cli/package.json').name)") | ||
| VER=$(node -e "console.log(require('./npx-cli/package.json').version)") | ||
| # Use inputs.version if available (from workflow_call), otherwise read from package.json | ||
| if [[ -n "${{ inputs.version }}" ]]; then | ||
| VER="${{ inputs.version }}" | ||
| echo "Using version from workflow input: $VER" | ||
| else | ||
| VER=$(node -e "console.log(require('./npx-cli/package.json').version)") | ||
| echo "Using version from package.json: $VER" | ||
| fi | ||
| echo "name=$NAME" >> $GITHUB_OUTPUT | ||
| echo "version=$VER" >> $GITHUB_OUTPUT | ||
| echo "Package: $NAME" | ||
| echo "Version: $VER" | ||
| echo "Package: $NAME@$VER" | ||
|
|
||
| - name: Check if version already published | ||
| id: check | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ members = [ | |
| ] | ||
|
|
||
| [workspace.package] | ||
| version = "0.8.7-rc.39" | ||
| version = "0.8.7-rc.40" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The workspace version is being bumped to |
||
| edition = "2024" | ||
| license = "MIT" | ||
| repository = "https://github.com/namastexlabs/forge-core" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For manual runs (
workflow_dispatch) the workflow defines an input namedtag, but the build checkout still usesinputs.version && format('v{0}', inputs.version) || github.ref. Becauseinputs.versionis unset in this path, the expression always resolves togithub.ref(usually the default branch), so dispatching the workflow with a specific tag builds the wrong revision. This can lead to publishing binaries that don’t match the requested tag.Useful? React with 👍 / 👎.