Add Classic Control Gymnax#90
Conversation
|
Pause until new CARL env was integrated. |
There was a problem hiding this comment.
Why call them Jax and not Gymnax? I bet there are other attempts at Jaxing them, Gymnax would be more explicit imo
There was a problem hiding this comment.
Env params is frozen for a reason, but I guess this runs, right? Pretty sure we can't jit it, but we have this issue with brax as well... at some point we might want to brainstorm if we can somehown avoid replacing env parts to change context. For now it's alright, though.
TheEimer
left a comment
There was a problem hiding this comment.
Looks good! One question though: have you tested if they're actually faster? In brax our context changes kind of break the speed, does it also happen here?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #90 +/- ##
================================================
+ Coverage 19.05% 48.10% +29.05%
================================================
Files 78 84 +6
Lines 4030 4122 +92
Branches 555 543 -12
================================================
+ Hits 768 1983 +1215
+ Misses 3224 2060 -1164
- Partials 38 79 +41 |
|
|
@benjamc Is this still feasible to integrate into the main package? And do you have an estimate of how much work this is? If not, then we could potentially remove this branch |
No description provided.