Fix OligosynthesizeOligo serialization#396
Open
Alberto024 wants to merge 1 commit intoautoprotocol:masterfrom
Open
Fix OligosynthesizeOligo serialization#396Alberto024 wants to merge 1 commit intoautoprotocol:masterfrom
Alberto024 wants to merge 1 commit intoautoprotocol:masterfrom
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #396 +/- ##
==========================================
- Coverage 84.57% 84.55% -0.02%
==========================================
Files 24 24
Lines 4589 4591 +2
==========================================
+ Hits 3881 3882 +1
- Misses 708 709 +1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example given in documentation for protocol.oligosynthesize does not work because OligosynthesizeOligo objects do not get properly serialized by protocol.as_dict() method:
Python Version: 3.11.4
Autoprotocol-python Version: 10.3.0
This pull request fixes this bug. There are a few other additional line changes from black formatting.