Skip to content

Enables virConnectListInterfaces to create guest xml via the framework#6798

Open
yiqianwei wants to merge 1 commit intoautotest:masterfrom
yiqianwei:LIBVIRTAT-22309
Open

Enables virConnectListInterfaces to create guest xml via the framework#6798
yiqianwei wants to merge 1 commit intoautotest:masterfrom
yiqianwei:LIBVIRTAT-22309

Conversation

@yiqianwei
Copy link
Contributor

@yiqianwei yiqianwei commented Feb 9, 2026

1.Add some parameters to allow the framework provide guest xml
2.Add "only Linux" to limit guest type

ID: LIBVIRTAT-22309

Summary by CodeRabbit

  • Tests
    • Marked the relevant test set as Linux-only to limit execution scope.
    • Enabled VM creation and termination within tests to exercise VM lifecycle.
    • Added an explicit firmware NVRAM option for the test firmware path to ensure consistent VM startup behavior.

@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

Walkthrough

A libvirt test configuration file for virtual network fuzzy testing was updated: four entries were added under virConnectListInterfaces in libvirt/tests/cfg/virtual_network/fuzzy_test/virConnectListInterface_test.cfg: only Linux, create_vm_libvirt = yes, kill_vm_libvirt = yes, and ovmf.kill_vm_libvirt_options = --nvram. These were added alongside existing start_vm = yes and func_supported_since_libvirt_ver = (10, 5, 0). No code logic or public interfaces were modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (5 files):

⚔️ libvirt/tests/cfg/cpu/multi_vms_with_stress.cfg (content)
⚔️ libvirt/tests/cfg/virtual_network/fuzzy_test/virConnectListInterface_test.cfg (content)
⚔️ libvirt/tests/cfg/virtual_network/hotplug/attach_detach_interface/attach_interface_with_options_and_vm_status.cfg (content)
⚔️ libvirt/tests/src/virtual_network/connectivity/connectivity_check_bridge_interface_unprivileged.py (content)
⚔️ libvirt/tests/src/virtual_network/hotplug/attach_detach_interface/attach_interface_with_options_and_vm_status.py (content)

These conflicts must be resolved before merging into master.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: enabling virConnectListInterfaces test case configuration to support guest XML creation via the test framework's VM creation/termination settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch LIBVIRTAT-22309
  • Post resolved changes as copyable diffs in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yiqianwei
Copy link
Contributor Author

Test results:
(1/1) Host_RHEL.m10.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.2.x86_64.io-github-autotest-libvirt.virtual_network.fuzzy_test.virConnectListInterfaces.set_0_number_interface.q35: PASS (12.18 s)

@yiqianwei
Copy link
Contributor Author

yiqianwei commented Feb 9, 2026

Hi @yanglei-rh , Could you help to review this patch? thanks

1.Add some parameters to allow the framework provide guest xml
2.Add "only Linux" to limit guest type

ID: LIBVIRTAT-22309

Signed-off-by: Yiqian Wei <yiwei@redhat.com>
@yiqianwei yiqianwei changed the title Enables virConnectListInterfaces test case to be supported under kar Enables virConnectListInterfaces to create guest xml via the framework Feb 13, 2026
Copy link
Contributor

@nickzhq nickzhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants