Skip to content

[guest os booting]fix bootmenu msg#6799

Open
zhentang-tz wants to merge 1 commit intoautotest:masterfrom
zhentang-tz:ovmf_msg_fix
Open

[guest os booting]fix bootmenu msg#6799
zhentang-tz wants to merge 1 commit intoautotest:masterfrom
zhentang-tz:ovmf_msg_fix

Conversation

@zhentang-tz
Copy link
Contributor

@zhentang-tz zhentang-tz commented Feb 10, 2026

update the check_prompt for ovmf cases to make them compatible with both the old and new versions

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Enhanced boot menu detection to support multiple boot entry types and applications instead of fixed configurations
    • Strengthened validation of boot menu configuration parameters for improved reliability

update the check_prompt for ovmf cases to make them compatible with both
the old and new versions

Signed-off-by: zhentang-tz <zhetang@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

Walkthrough

The changes update boot menu validation logic in test configurations and source code. A configuration file modifies the boot menu prompt pattern from matching a specific boot entry ("Boot0000" UiApp) to a more flexible regex pattern that matches Boot entries with dynamic indices and allows either UiApp or BootManagerMenuApp. Simultaneously, the Python source code adds a length validation check, requiring the check_not_prompt list to contain at least 3 elements before executing boot menu output parsing logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check ✅ Passed The title accurately describes the main change: fixing boot menu messaging for OVMF cases to support compatibility with multiple versions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@zhentang-tz
Copy link
Contributor Author

Test name
Duration
Status
bootmenu.by_ovmf.positive_test.timeout_6000 1 min 4 sec Fixed
bootmenu.by_ovmf.positive_test.timeout_65535 2 min 47 sec Fixed
bootmenu.by_seabios.positive_test.timeout_6000 41 sec Fixed
bootmenu.by_seabios.positive_test.timeout_65535 1 min 37 sec Fixed

@zhentang-tz zhentang-tz marked this pull request as ready for review February 11, 2026 08:40
@zhentang-tz zhentang-tz changed the title [guest os booting]fix bootmanu msg [guest os booting]fix bootmenu msg Feb 11, 2026
[check_prompt], timeout=30, internal_timeout=0.5
)
if check_not_prompt:
if check_not_prompt and len(check_not_prompt) >= 3:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why we need to have the condition len(check_not_prompt) >= 3. I found in cfg file it only has one check_not_prompt with check_not_prompt = LOADPARM=.2,s390-ccw Enumerated Boot Menu,.*Linux version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants