Skip to content

Snapshot: update pattern to avoid conflict#6825

Merged
cliping merged 1 commit intoautotest:masterfrom
meinaLi:fix_snapshot
Mar 11, 2026
Merged

Snapshot: update pattern to avoid conflict#6825
cliping merged 1 commit intoautotest:masterfrom
meinaLi:fix_snapshot

Conversation

@meinaLi
Copy link
Contributor

@meinaLi meinaLi commented Mar 11, 2026

This script is basically no longer tested, but its pattern can affect new cases. Since the new cases are not recommended to update, I modified this one to avoide conflict.

Summary by CodeRabbit

  • Chores
    • Updated test configuration parameters related to snapshot handling.

This script is basically no longer tested, but its pattern can affect
new cases. Since the new cases are not recommended to update, I modified
this one to avoide conflict.

Signed-off-by: Meina Li <meili@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 75b30a97-7cfe-4f61-947c-f68bcc07fb88

📥 Commits

Reviewing files that changed from the base of the PR and between 230d80d and 04f5c1d.

📒 Files selected for processing (1)
  • libvirt/tests/cfg/resource_abnormal.cfg

Walkthrough

This pull request systematically renames the snapshot-related configuration keyword from snapshot_create to snapshot_creation across multiple entries in the resource abnormal test configuration file. The changes affect variant definitions for once_execute, twice_execute, leave_first options, and the top-level variants list. No structural or logical modifications are introduced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly references the core change: renaming snapshot_create to snapshot_creation to avoid pattern conflicts with new test cases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@meinaLi
Copy link
Contributor Author

meinaLi commented Mar 11, 2026

The old cases pattern which are not expected to get resource.abnormal ones:

# avocado list --vt-type libvirt | grep snapshot_create | grep -v snapshot_create_as
avocado-vt type_specific.io-github-autotest-libvirt.snapshot_create.manual_snapshot.one_manual_snapshot
avocado-vt type_specific.io-github-autotest-libvirt.snapshot_create.manual_snapshot.three_manual_snapshots
avocado-vt type_specific.io-github-autotest-libvirt.resource_abnormal.snapshot_create.normal_resource.twice_execute.kill_first
avocado-vt type_specific.io-github-autotest-libvirt.resource_abnormal.snapshot_create.memory_lack
avocado-vt type_specific.io-github-autotest-libvirt.resource_abnormal.snapshot_create.cpu_busy

After fix, we can only get snapshot_create cases which can be directly used in snapshot auto job:

# avocado list --vt-type libvirt | grep snapshot_create | grep -v snapshot_create_as
avocado-vt type_specific.io-github-autotest-libvirt.snapshot_create.manual_snapshot.one_manual_snapshot
avocado-vt type_specific.io-github-autotest-libvirt.snapshot_create.manual_snapshot.three_manual_snapshots

@cliping cliping merged commit 4ad8f8f into autotest:master Mar 11, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants