Skip to content

test configs: increase memory allocation for libvirt_mem, memory_discard, and nvdimm cases#6826

Open
liang-cong-red-hat wants to merge 1 commit intoautotest:masterfrom
liang-cong-red-hat:increase_memory_avoid_boot_failure
Open

test configs: increase memory allocation for libvirt_mem, memory_discard, and nvdimm cases#6826
liang-cong-red-hat wants to merge 1 commit intoautotest:masterfrom
liang-cong-red-hat:increase_memory_avoid_boot_failure

Conversation

@liang-cong-red-hat
Copy link
Contributor

@liang-cong-red-hat liang-cong-red-hat commented Mar 11, 2026

Starting from rhel10 the minimal require of memory is 2G, so update the test configuration parameters in 'libvirt_mem.cfg', 'memory_discard.cfg', and 'nvdimm.cfg' to accommodate larger memory requirements.

Test results:
(1/4) type_specific.io-github-autotest-libvirt.nvdimm.back_file.label.default: STARTED
(1/4) type_specific.io-github-autotest-libvirt.nvdimm.back_file.label.default: PASS (81.23 s)
(1/1) type_specific.io-github-autotest-libvirt.nvdimm.back_file.no_label: STARTED
(1/1) type_specific.io-github-autotest-libvirt.nvdimm.back_file.no_label: PASS (512.19 s)
(1/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.discard_yes: STARTED
(1/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.discard_yes: PASS (49.66 s)
(2/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.shared_yes: STARTED
(2/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.shared_yes: PASS (52.75 s)
(3/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.shared_no: STARTED
(3/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.shared_no: PASS (58.20 s)
(4/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.type_file: STARTED
(4/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.type_file: PASS (52.13 s)
(5/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.type_anon: STARTED
(5/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.type_anon: PASS (52.08 s)
(6/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.discard_no: STARTED
(6/6) type_specific.io-github-autotest-libvirt.memory_discard.common.numa_cell.discard_no: PASS (58.63 s)
(1/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.discard_yes: STARTED
(1/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.discard_yes: PASS (47.96 s)
(2/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.shared_yes: STARTED
(2/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.shared_yes: PASS (57.56 s)
(3/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.shared_no: STARTED
(3/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.shared_no: PASS (98.09 s)
(4/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.type_file: STARTED
(4/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.type_file: PASS (49.71 s)
(5/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.type_anon: STARTED
(5/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.type_anon: PASS (52.45 s)
(6/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.discard_no: STARTED
(6/6) type_specific.io-github-autotest-libvirt.memory_discard.common.mem_dev.discard_no: PASS (51.57 s)

(1/5) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.memory.hot.plug.default: STARTED
(1/5) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.memory.hot.plug.default: PASS (123.38 s)
(2/5) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.memory.hot.unplug.default: STARTED
(2/5) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.memory.hot.unplug.default: PASS (132.32 s)
(3/5) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.memory.cold.plug.default: STARTED
(3/5) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.memory.cold.plug.default: PASS (104.63 s)
(4/5) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.memory.cold.unplug.default: STARTED
(4/5) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.memory.cold.unplug.default: PASS (107.96 s)
(5/5) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.memory.cold.detach_device_alias.default: STARTED
(5/5) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.memory.cold.detach_device_alias.default: PASS (103.61 s)

(1/1) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.no_attach: STARTED
(1/1) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.no_attach: PASS (98.19 s)
(01/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.no_numatune.hot_plug: STARTED
(01/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.no_numatune.hot_plug: PASS (137.29 s)
(02/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.no_numatune.hot_unplug: STARTED
(02/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.no_numatune.hot_unplug: PASS (137.19 s)
(03/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.no_numatune.cold_plug: STARTED
(03/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.no_numatune.cold_plug: PASS (105.50 s)
(04/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.no_numatune.cold_plug_discard: STARTED
(04/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.no_numatune.cold_plug_discard: PASS (103.68 s)
(05/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.no_numatune.discard: STARTED
(05/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.no_numatune.discard: PASS (134.38 s)
(06/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.with_numatune.hot_plug: STARTED
(06/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.with_numatune.hot_plug: PASS (141.39 s)
(07/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.with_numatune.hot_unplug: STARTED
(07/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.with_numatune.hot_unplug: PASS (140.44 s)
(08/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.with_numatune.cold_plug: STARTED
(08/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.with_numatune.cold_plug: PASS (111.26 s)
(09/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.with_numatune.cold_plug_discard: STARTED
(09/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.with_numatune.cold_plug_discard: PASS (107.83 s)
(10/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.with_numatune.discard: STARTED
(10/10) type_specific.io-github-autotest-libvirt.libvirt_mem.positive_test.hugepages.with_numatune.discard: PASS (130.22 s)
(1/6) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_nonexist_node: STARTED
其 (1/6) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_nonexist_node: PASS (68.20 s)
(2/6) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_invalid_type: STARTED
(2/6) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_invalid_type: PASS (71.45 s)
(3/6) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_duplicate_node: STARTED
(3/6) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_duplicate_node: PASS (71.47 s)
(5/6) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_invalid_size: STARTED
(5/6) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_invalid_size: PASS (70.51 s)
(6/6) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_gt_max: STARTED
(6/6) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_gt_max: PASS (113.61 s)
(1/1) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_many_times: STARTED
(1/1) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.attach_error.attach_many_times: PASS (65.73 s)

(1/4) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.detach_error.detach_invalid_type: STARTED
(1/4) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.detach_error.detach_invalid_type: PASS (114.38 s)
(2/4) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.detach_error.detach_duplicate_node: STARTED
(2/4) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.detach_error.detach_duplicate_node: PASS (74.72 s)
(3/4) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.detach_error.detach_many_times: STARTED
(3/4) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.detach_error.detach_many_times: PASS (77.34 s)
(4/4) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.detach_error.detach_invalid_size: STARTED
(4/4) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.detach_error.detach_invalid_size: PASS (71.04 s)

(1/2) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.setmem_error.without_numa: STARTED
(1/2) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.setmem_error.without_numa: PASS (64.54 s)
(2/2) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.setmem_error.with_numa: STARTED
(2/2) type_specific.io-github-autotest-libvirt.libvirt_mem.negative_test.setmem_error.with_numa: PASS (70.77 s)

Summary by CodeRabbit

  • Tests
    • Updated memory allocation configurations across multiple libvirt test scenarios. Changes include increased NUMA cell memory allocations, higher VM runtime and maximum memory settings, and larger memory device thresholds. Updates are applied across positive/negative test variants, attach/detach operations, memory discard scenarios, NVDIMM testing, and hot plug operations to provide comprehensive memory configuration coverage.

…ard, and nvdimm cases

Starting from rhel10 the minimal require of memory is 2G, so update the
test configuration parameters in 'libvirt_mem.cfg', 'memory_discard.cfg',
and 'nvdimm.cfg' to accommodate larger memory requirements.

Signed-off-by: Liang Cong <lcong@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f0480687-be59-4cf9-8102-a0a17883d32d

📥 Commits

Reviewing files that changed from the base of the PR and between 4ad8f8f and d33df7a.

📒 Files selected for processing (3)
  • libvirt/tests/cfg/libvirt_mem.cfg
  • libvirt/tests/cfg/memory/memory_discard.cfg
  • libvirt/tests/cfg/memory/nvdimm.cfg

Walkthrough

The pull request updates memory allocation parameters across three libvirt test configuration files. Changes include increasing max_mem_rt, max_mem, current_mem, numa_cells memory allocations, setvm values, and qemu_checks size thresholds. Specifically, libvirt_mem.cfg increases memory values in positive and negative test variants; memory_discard.cfg raises cpuxml_numa_cell memory, setvm settings, and qemu_checks sizes across common, mem_dev, and hot_plug blocks; nvdimm.cfg increases NUMA memory and VM runtime settings in label, no_label, and hot_plug sections. No public or exported entities are altered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: increasing memory allocation values across three test configuration files (libvirt_mem, memory_discard, and nvdimm).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant