ci(release): restrict core release trigger to v[0-9]* tags#249
Merged
Conversation
The `v*` glob accidentally matched adapter tags that happen to start with 'v', most notably `vue-v0.1.0`. When that tag was pushed during the adapter release sequence, the main `release` workflow queued alongside `release-vue` and would have overwritten the Vue GitHub Release name had it not been cancelled. Tightening the glob to `v[0-9]*` restricts the core release to genuine semver tags (v3.3.0, v3.4.0-rc.1, etc.) and isolates each adapter release to its dedicated workflow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix to the trigger glob in `.github/workflows/release.yml`.
The current `v*` glob accidentally matches adapter tags that happen to start with 'v' — `vue-v0.1.0` being the obvious one. When that tag was pushed during the Svelte/Solid/Vue adapter release sequence (PR #248 follow-up), the main `release` workflow queued alongside `release-vue` and would have overwritten the Vue GitHub Release name had it not been cancelled in flight (`gh run cancel 26450464475`).
Tightening to `v[0-9]` restricts the core release to genuine semver tags (`v3.3.0`, `v3.4.0-rc.1`, etc.) and isolates each adapter release to its dedicated workflow. No other adapter tag patterns are affected (`react-v`, `angular-v*`, `svelte-v*`, `solid-v*` start with letters, not 'v').
Test plan
🤖 Generated with Claude Code