feat(dashboard): expose --prune-dangling cleanup target#446
Open
aviadshiber wants to merge 3 commits into
Open
feat(dashboard): expose --prune-dangling cleanup target#446aviadshiber wants to merge 3 commits into
aviadshiber wants to merge 3 commits into
Conversation
kapsis-cleanup.sh gained a standalone --prune-dangling flag for cheap, in-use-safe dangling-layer GC (cron/housekeeper use case), but the dashboard's cleanup control surface never learned about it. Add a "prune-dangling" entry to TARGET_TO_FLAG, surface it in the Maintenance UI's target list, and extend the cleanup control tests to cover the new mapping. Fixes #424
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kapsis-cleanup.shadded a standalone--prune-danglingflag (cheap, in-use-safe dangling-layer GC for cron/housekeepers), but the dashboard's cleanup control surface didn't expose it yet, per CLAUDE.md's Dashboard Sync Rule.prune-danglingentry toTARGET_TO_FLAGindashboard/server/src/control/cleanup.tsmapping to--prune-dangling.dashboard/server/tests/cleanup.test.tsto cover the new target/flag mapping.Fixes #424
Test plan
./tests/run-all-tests.sh --quick(shell test suite, unaffected by this TS-only change)bun test dashboard/server/tests/cleanup.test.ts(bun not available in this environment; new test follows the exact pattern of existing target tests)